! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
>1 row panel + "use only 1 row" unticked = small icon and empty margins
Status:
RESOLVED: WONTFIX
Product:
Xfce4-whiskermenu-plugin
Component:
General

Comments

Description Jesús Guerrero Botella 2015-03-05 18:59:14 CET
Hi!

I am using a new panel layout with 3 rows, because it lets me lay things better. The problem with this is that then the whisker menu icon appears small and centered in the available space.

Longer icons that are horizontal (WinXp-like, to put it simple and plain) work fine, but I want it to look well with square icons, just like when you have a single row panel layout.

I will attach a screenshot of what it looks like right now, a patch to "fix" the issue, and a second shot with how it looks like with a 3-rows panel and my patch applied.
Comment 1 Jesús Guerrero Botella 2015-03-05 19:00:55 CET
Created attachment 6034 
How it looks like right now

This is how the current whisker menu icon looks. In the shot, it's the first icon, in the top-left corner of the screen. You can see there's a lot of empty space around the icon because the row-height is used as the max icon height.
Comment 2 Jesús Guerrero Botella 2015-03-05 19:02:29 CET
Created attachment 6035 
This is how I would like it to be

You can see the icon look as it would look in a single row layout. It fills the whole panel width and it's easier to see and click.
Comment 3 Jesús Guerrero Botella 2015-03-05 19:06:08 CET
Created attachment 6036 
+1 row big icon patch

Nothing magical. I think that, in this case, it would be better to set the max icon height to match the max icon width so that it allows for square icons. As far as I tested this doesn't break horizontal xp-esque menu buttons, but I only did a couple of quick tests, admittedly.
Comment 4 Jesús Guerrero Botella 2015-03-05 19:12:07 CET
Created attachment 6037 
+1 row big icon patch

Ooops. Previous one broke the case for +1 rows in the panel where you wanted to have the whisker icon to occupy one single row. This one fixes that.
Comment 5 Graeme Gott editbugs 2015-03-06 11:13:47 CET
I'm sorry, but I consider the behavior you want it to have to be a bug. It doesn't match any other plugin I have tested (especially not the default applications menu), and it would make the button huge the more rows your panel has.
Comment 6 Jesús Guerrero Botella 2015-03-06 11:43:39 CET
(In reply to Graeme Gott from comment #5)
> I'm sorry, but I consider the behavior you want it to have to be a bug. It
> doesn't match any other plugin I have tested (especially not the default
> applications menu), and it would make the button huge the more rows your
> panel has.

Hi.

Don't worry, I will keep it as a local patch then. Sorry for the noise. I find it weird that there's  no width limit but there's an height limit though, but to each his/her own I suppose.

Thanks anyway for the prompt reply :)

Bug #11647

Reported by:
Jesús Guerrero Botella
Reported on: 2015-03-05
Last modified on: 2015-03-06

People

Assignee:
Graeme Gott
CC List:
0 users

Version

Attachments

How it looks like right now (235.26 KB, image/jpeg)
2015-03-05 19:00 CET , Jesús Guerrero Botella
no flags
This is how I would like it to be (247.93 KB, image/jpeg)
2015-03-05 19:02 CET , Jesús Guerrero Botella
no flags
+1 row big icon patch (612 bytes, patch)
2015-03-05 19:06 CET , Jesús Guerrero Botella
no flags
+1 row big icon patch (647 bytes, patch)
2015-03-05 19:12 CET , Jesús Guerrero Botella
no flags

Additional information