! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
On BSD systems, stat command has '-f' option (equivalent of '-c' under Linux)
Status:
RESOLVED: FIXED
Product:
Xfce4-settings
Component:
Appearance Settings

Comments

Description Olivier Duchateau 2015-02-11 22:52:13 CET
Created attachment 5929 
Patch to support BSD system in dialogs/appearance-settings/appearance-install-theme

On BSD systems, '-c' option doesn't exist in stat command, it's '-f' option.
Comment 1 Olivier Duchateau 2015-02-12 06:48:08 CET
Created attachment 5932 
Support BSD systems in dialogs/appearance-settings/appearance-install-theme
Comment 2 Steve Dodier-Lazaro editbugs 2015-02-15 03:56:56 CET
Can't test that patch, though could you please clarify if the -c option is specific to Linux, or if it's commonly used across POSIX systems?

If it's commonly used (and if indeed BSD is the "different" one), then you should test for all flavours of BSD instead of testing for flavours of Linux. Otherwise this might break on Solaris / HP AIX / <insert obscure flavour even the maintainers are unaware of> systems.
Comment 3 Olivier Duchateau 2015-02-15 21:02:35 CET
Created attachment 5943 
Patch to support BSD system in dialogs/appearance-settings/appearance-install-theme

On BSD systems (see FreeBSD [1], NetBSD [2], and OpenBSD [3] man pages), -c option doesn't exist, it's -f. I don't know for others systems except Linux.

Note: DragonFly is FreeBSD fork, so same command.

[1] https://www.freebsd.org/cgi/man.cgi?query=stat&manpath=FreeBSD+10.1-RELEASE
[2] http://netbsd.gw.com/cgi-bin/man-cgi?stat++NetBSD-current
[3] http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man1/stat.1?query=stat
Comment 4 Steve Dodier-Lazaro editbugs 2015-02-16 01:59:55 CET
Great, thanks Olivier! Adding this to the list of patches to commit.
Comment 5 Sean Davis editbugs 2015-02-16 05:32:23 CET
Applied at http://git.xfce.org/xfce/xfce4-settings/commit/?id=4df7dbd3e50f08d2e039a1cb36733a7dfef0a245

Thanks for the patch! This will be included in the upcoming xfce4-settings 4.11.4

Bug #11531

Reported by:
Olivier Duchateau
Reported on: 2015-02-11
Last modified on: 2015-02-16

People

Assignee:
Nick Schermer
CC List:
4 users

Version

Version:
4.11.0

Attachments

Additional information