! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] Makefile.am, define generated files
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
enhancement
Product:
Thunar
Component:
Core

Comments

Description Matt32 2015-02-01 20:06:53 CET 
Created attachment 5892 
Thunar Makefile.am patch

With this patch, generated files are not mixed with typed source files.
Comment 1 Steve Dodier-Lazaro editbugs 2015-02-08 19:27:49 CET 
@Matt32: What problem does this patch fix?

@maintainers: this patch causes no regression for me.
Comment 2 Matt32 2015-02-09 20:25:20 CET 
This patch does not fix anything. It simplifies the Makefile to avoid confusion between what is generated by a tool and what is coded by the developpers.
But, as discussed on IRC, it could be improved by merging $(thunar_generated_sources) into $(thunar_built_sources).
Comment 3 Steve Dodier-Lazaro editbugs 2015-02-10 14:16:54 CET 
Thanks for clarifying Matt. Could you please propose a patch that contains the discussed improvements? This report is on the list of 4.12 bugs so the patch can then be applied before the 4.12 release.

Thanks.
Comment 4 Matt32 2015-02-11 20:39:45 CET 
Created attachment 5926 
Improved version
Comment 5 Steve Dodier-Lazaro editbugs 2015-02-11 23:18:58 CET 
Improved patch builds and runs for me.

Bug #11492

Reported by:
Matt32
Reported on: 2015-02-01
Last modified on: 2015-02-19

People

Assignee:
Xfce Bug Triage
CC List:
4 users

Version

Version:
1.6.3
Target Milestone:
2.0.0

Attachments

Thunar Makefile.am patch (4.46 KB, patch)
2015-02-01 20:06 CET , Matt32 		no flags
Improved version (4.22 KB, patch)
2015-02-11 20:39 CET , Matt32 		no flags

Additional information