Hi! I've been getting awful systemd journal spam from what I believe to be ffmpegthumbnailer through tumbler while thunar is open in a folder where videos are being downloaded. ~10 messages like this per second with only 2 running downloads: org.freedesktop.thumbnails.Thumbnailer1[3558]: [h264 @ 0x7f360d0b3300] AVC: nal size 0 The amount of journal spam this generates on my machine dominates my logs and renders having a system journal open in the first place totally useless. It can accumulate millions of unnecessary lines in the logs over the course of a month with normal usage. Tumbler should probably not relay all of the output generated by the programs it calls to the systemd journal. Also Tumbler / Thunar should probably not try to generate / request thumbnails for the same file over and over again with such a high frequency while it is still being downloaded. Using tumbler 0.1.30
This bug is actually more severe than it might seem at first: The journal daemon usually runs with elevated privileges, so it can fill the harddisk to the very last byte, rendering the system unusable. That's already very inconvenient on a single-user system, but combined with a bug in a thumbnailer [1], it can become an attack vector for unprivileged local users on a shared system [2]. It's suboptimal that journald allows this to happen, but perhaps it can also be prevented in tumbler? I don't have a ready solution unfortunately, but perhaps a cut-off after a certain amount of output would help, and/or a timeout for any thumbnailers invoked by tumbler? [1]: https://gitlab.gnome.org/GNOME/dia/issues/428 [2]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-19451
Just experienced this problem while/after downloading videos to a folder that was open in Thunar. `rsyslogd` used 100% of one CPU core. After a `killall tumblerd` and re-opening the folder in Thunar, the thumbnails were then generated correctly. /var/log/syslog has the following lines: May 9 07:56:18 XXX tumblerd[27936]: gst_poll_read_control: assertion 'set != NULL' failed May 9 07:56:51 XXX tumblerd[27936]: message repeated 909205 times: [ gst_poll_read_control: assertion 'set != NULL' failed] May 9 07:56:51 XXX tumblerd[27936]: gst_poll_read_control: assertion 'set != NULL' failed (Does that mean 909205 messages were logged between 07:56:18 and 07:56:51?)
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/tumbler/-/issues/10. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev