! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[PATCH] dialogs/display-settings: Initialise x,y in on_area_paint().
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Xfce4-settings
Component:
Display Settings

Comments

Description Jactry Zeng 2014-08-17 14:10:34 CEST 
Created attachment 5604 
patch

x, y in on_area_paint() didn't be initialised. (by Valgrind)

Valgrind log:
==29037== Conditional jump or move depends on uninitialised value(s)
==29037==    at 0x80525FD: paint_output (main.c:2361)
==29037==    by 0x805330A: on_area_paint (main.c:2525)
==29037==    by 0x805AB94: foo_marshal_VOID__POINTER_BOXED_POINTER (foo-marshal.c:237)
==29037==    by 0x4731A7D: g_closure_invoke (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x4744028: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x474B962: g_signal_emit_valist (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x474BBF2: g_signal_emit (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x80588A3: foo_scroll_area_expose (scrollarea.c:522)
==29037==    by 0x41A5EBD: ??? (in /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0.2400.23)
==29037==    by 0x47305A3: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x47319F1: g_closure_invoke (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x4743C7F: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037== 
==29037== Conditional jump or move depends on uninitialised value(s)
==29037==    at 0x805263E: paint_output (main.c:2361)
==29037==    by 0x805330A: on_area_paint (main.c:2525)
==29037==    by 0x805AB94: foo_marshal_VOID__POINTER_BOXED_POINTER (foo-marshal.c:237)
==29037==    by 0x4731A7D: g_closure_invoke (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x4744028: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x474B962: g_signal_emit_valist (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x474BBF2: g_signal_emit (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x80588A3: foo_scroll_area_expose (scrollarea.c:522)
==29037==    by 0x41A5EBD: ??? (in /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0.2400.23)
==29037==    by 0x47305A3: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x47319F1: g_closure_invoke (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x4743C7F: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037== 
==29037== Conditional jump or move depends on uninitialised value(s)
==29037==    at 0x8052687: paint_output (main.c:2365)
==29037==    by 0x805330A: on_area_paint (main.c:2525)
==29037==    by 0x805AB94: foo_marshal_VOID__POINTER_BOXED_POINTER (foo-marshal.c:237)
==29037==    by 0x4731A7D: g_closure_invoke (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x4744028: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x474B962: g_signal_emit_valist (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x474BBF2: g_signal_emit (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x80588A3: foo_scroll_area_expose (scrollarea.c:522)
==29037==    by 0x41A5EBD: ??? (in /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0.2400.23)
==29037==    by 0x47305A3: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x47319F1: g_closure_invoke (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x4743C7F: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037== 
==29037== Conditional jump or move depends on uninitialised value(s)
==29037==    at 0x80526C8: paint_output (main.c:2365)
==29037==    by 0x805330A: on_area_paint (main.c:2525)
==29037==    by 0x805AB94: foo_marshal_VOID__POINTER_BOXED_POINTER (foo-marshal.c:237)
==29037==    by 0x4731A7D: g_closure_invoke (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x4744028: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x474B962: g_signal_emit_valist (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x474BBF2: g_signal_emit (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x80588A3: foo_scroll_area_expose (scrollarea.c:522)
==29037==    by 0x41A5EBD: ??? (in /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0.2400.23)
==29037==    by 0x47305A3: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x47319F1: g_closure_invoke (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
==29037==    by 0x4743C7F: ??? (in /usr/lib/i386-linux-gnu/libgobject-2.0.so.0.4000.0)
Comment 1 Simon Steinbeiss editbugs 2014-08-20 20:49:54 CEST 
Thanks, looks good. Merged to master.

Bug #11084

Reported by:
Jactry Zeng
Reported on: 2014-08-17
Last modified on: 2014-08-20

People

Assignee:
Jérôme Guelfucci
CC List:
4 users

Version

Version:
4.11.0
Target Milestone:
Xfce 4.6

Attachments

patch (1.17 KB, text/plain)
2014-08-17 14:10 CEST , Jactry Zeng 		no flags

Additional information