! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Shadow Fix and Transparent TitleBar & Border
Status:
RESOLVED: FIXED
Severity:
enhancement

Comments

Description Aquila Deus 2005-08-06 15:43:52 CEST
Hi all! I tweaked the compositor.c in xfwm 4.3
(http://www.xfce.org/~olivier/preview/xfwm4-4.3.0-r16067.tar.bz2 ).

It adds:

- shadow radius becomes 12 pixels
- All windows have opacity 0.75
- All dialog boxes have opacity 0.8
- All popups (menus) have opacity 0.775
- Window titlebars and borders have opacity 0.55
- Remove options checking for enable/disable shadow (always shadowed!)
- Subtract window content region from shadow. That fixes the gtk2 scrolling
problem (contents often mess up when scrolling) and improves performance. And my
X doesn't crash anymore (used to crash every 2-3 days).

My environment: kernel 2.6.12.3, xorg 6.8.2, nVidia FX5500 with official driver
1.0-7667, gtk2 2.6.9, xfce 4.2.2 (only xfwm is 4.3)

Screenshot here => http://www.aquila-deus.no-ip.org/screenshots/Firefox-CSS.png
Comment 1 Aquila Deus 2005-08-06 15:45:32 CEST
Created attachment 286 
patch for xfwm4-4.3.0/src/compositor.c

Patch against http://www.xfce.org/~olivier/preview/xfwm4-4.3.0-r16067.tar.bz2
Comment 2 Olivier Fourdan editbugs 2005-08-06 22:07:10 CEST
I personally don't like too much transparency. But other ppl may like your patch
and use it.

BTS, the shadow radius is configurable, you shouldn't need a patch for that.
Comment 3 Aquila Deus 2005-08-08 05:18:33 CEST
(In reply to comment #2)
> I personally don't like too much transparency. But other ppl may like your 
patch
> and use it.

Uhh, but what about the titlebar and border transparency? Will it be added to 
next xfwm release?
Comment 4 Olivier Fourdan editbugs 2005-08-08 19:51:16 CEST
I tried it, I had to apply the patch by hand because it doesn't apply.
This really adds too much transparency and it not luch usable, frankly.

I like the removal of the window content region being "substracted" from the
shadow, it allows for argb + shadow windows, that's cool.

I disagree though that it fixes any issue with the compositor, because the issue
you describe are with the proprietary closed source NVidia drivers, and not with
the compositing manager (the shadow are unusable with any NVidia driver above
6629 for my Geforce4 while it works perfectly with 6629)

I have no problem of any kind with the open source drivers.

Anyway, I took the shadowClip part, re-indent and rearrange the code a bit and
applied this. For the transparency, it really hurts usability too much for me
(and worst of all, it looks like Vista, pwah! ;)
Comment 5 Aquila Deus 2005-08-20 14:56:09 CEST
tested with gtk 2.8.0, no problem until now.

New Screenshot => http://photos31.flickr.com/35281445_504ae247fa_o.png

:))
Comment 6 Olivier Fourdan editbugs 2006-03-13 22:55:18 CET
Ok, there is now something similar (and based partly on you work) in svn, but it
goes a bit further by allowing translucent frames with opaque windows (ie set
the frame opacity independently from the window opacity itself).

I'm therefore closing that request. 

Thanks,
Olivier.
Comment 7 Aquila Deus 2006-03-14 09:03:48 CET
(In reply to comment #6)
> Ok, there is now something similar (and based partly on you work) in svn, but it
> goes a bit further by allowing translucent frames with opaque windows (ie set
> the frame opacity independently from the window opacity itself).

Hi! It'd be better if active windows and inactive ones can have different frame
opacity, otherwise the text on the active titlebar could be easily messed up by
a browser or text editor in background. In vista it blurs background windows to
avoid that, but I dont think it's currently possible to implement any kind of
blurring effect on X.

Bug #1103

Reported by:
Aquila Deus
Reported on: 2005-08-06
Last modified on: 2009-07-14

People

Assignee:
Olivier Fourdan
CC List:
0 users

Version

Attachments

Additional information