! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
session management support broken
Status:
RESOLVED: MOVED
Product:
Xfce4-session
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2014-06-18 15:51:44 CEST
Hi,

I recently disabled “legacy” (X11R5) session management in xfce4-session in Debian, and it seems that this revealed some kind of bug.

A Debian user (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751725) reported that his session was not saved anymore (he tried rxvt and various x11-apps). It seems that only Xfce-based apps (I guess linked against libxfce4ui or libxfce4util) are saved in the session, along with few exceptions (calibre for example).

I'm unsure where the problem really lies, but there definitely seem to be a problem.

Any pointer on how to debug this further is welcome.
Comment 1 Eric Koegel editbugs 2014-09-28 17:55:20 CEST
So this bug is fun.

First you can kinda see what xfsm is up to by defining the XFSM_VERBOSE but it wasn't showing as much as I would like, so there's a patch in git master to do more.

I was using a couple applications to start with but narrowed things down to just devhelp. I did notice the warning in the .xsession-errors:
(devhelp:29884): Gtk-WARNING **: Failed to register client: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.SessionManager was not provided by any .service files
But there's https://wiki.gnome.org/Projects/SessionManagement/NewGnomeSession which still was talking about using xsmp so I figured everything was ok and the bug is still in xfsm.

I also know most of the gnome applications are going over to GtkApplication in GTK3. So I looked in there and https://developer.gnome.org/gtk3/3.14/GtkApplication.html#GtkApplication--register-session it's supposed to handle it for the clients. Awesome. It defaults to disabled, but good enough as devhelp does set it to TRUE in dh_app_new:
https://git.gnome.org/browse/devhelp/tree/src/dh-app.c#n382

Looking around GTK+ in the various application files, I didn't see anything referencing xsmp and hardcoded calls to org.gnome.SessionManager in gtk_application_impl_dbus_startup
https://git.gnome.org/browse/gtk+/tree/gtk/gtkapplication-dbus.c#n135

So I'm guessing everyone is expected to copy gnome's SessionManager DBUS API or keep using the "legacy" session management? I not sure copying gnome's API is a great idea as they control both GTK and the session manager and can change things in lock-step (i.e GTk 3.14 with Gnome 3.14) but break things for us.

I haven't looked into KDE's session manager at this time.
Comment 2 Matias De lellis 2014-09-29 03:23:20 CEST
Hi,
It does not add much information but this is the related bug in gnome:

* https://bugzilla.gnome.org/show_bug.cgi?id=693203

Not many intentions to fix it for now. :(

Regards.
Comment 3 Eric Koegel editbugs 2014-11-05 17:45:25 CET
Thanks for linking in the bug report Matias. Since this looks like there's some
dbus methods to write in and it may take a while, it's been postponed from
being a "critical bug" for 4.12. But it's on the todo list
Comment 4 Yves-Alexis Perez editbugs 2014-11-05 18:13:11 CET
(In reply to Eric Koegel from comment #3)
> Thanks for linking in the bug report Matias. Since this looks like there's
> some
> dbus methods to write in and it may take a while, it's been postponed from
> being a "critical bug" for 4.12. But it's on the todo list

Note that same thing happens in 4.8 and 4.10.
Comment 5 Eric Koegel editbugs 2014-11-05 18:23:28 CET
Yeah, it's a change on Gnome's end. I assume to support wayland and mir. Looks like we need to implement:
https://git.gnome.org/browse/gnome-session/tree/gnome-session/org.gnome.SessionManager.xml
and
https://git.gnome.org/browse/gnome-session/tree/gnome-session/org.gnome.SessionManager.ClientPrivate.xml
Comment 6 martin.babutzka 2015-01-21 13:27:28 CET
*** Bug 11470 has been marked as a duplicate of this bug. ***
Comment 7 martin.babutzka 2015-01-21 14:20:15 CET
Can confirm this bug. Thunar, xfce4-terminal and firefox are restored while the gnome application evolution is not loaded. Evolution does not even appear in xfce4-session-settings.

Are there any updates on this or beta-code which might be tested?

Kind regards,
Martin
Comment 8 Git Bot editbugs 2020-05-26 00:46:04 CEST
-- GitLab Migration Automatic Message --

This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-session/-/issues/24.

Please create an account or use an existing account on one of our supported OAuth providers. 

If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests

Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev

Bug #10963

Reported by:
Yves-Alexis Perez
Reported on: 2014-06-18
Last modified on: 2020-05-26
Duplicates (1):
  • 11470 Session manager fails to save&restore evolution mail client

People

Assignee:
Xfce Bug Triage
CC List:
6 users

Version

Version:
4.10.1

Attachments

Additional information