! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-power-manager 1.3.0: runs sudo process unasked
Status:
RESOLVED: FIXED
Product:
Xfce4-power-manager
Component:
General

Comments

Description haarp 2014-06-06 08:14:15 CEST
Whenever I log in using the new power manager, it starts a new sudo process:

sudo -H -S -p XFPM_SUDO_PASS  -- /usr/bin/xfce4-pm-helper

this in turn pops up my fingerprint reader dialog asking me to swipe my finger.


It seems to be checking whether sudo can be used to escalate privileges, but doesn't consider that this might trigger events (such as a fingerprint reader) that do not return a traditional password dialog.

xfce4-pm-helper should simply be installed suid instead if root is required.
Comment 1 Eric Koegel editbugs 2014-08-08 20:31:40 CEST
Created attachment 5600 
Use pkexec for pm-helper

This patch switches from the sudo helper to pkexec which should allow you to use your fingerprint reader. Let me know how this works out, thanks!
Comment 2 Eric Koegel editbugs 2014-08-10 08:38:04 CEST
Pushed this patch with a couple minor changes to master. You'll see it in a dev release shortly.

commit 9ec0514fd9972373c1875ff3b80054145a445d9f
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Sat Aug 9 22:21:56 2014 +0300

    Use pkexec for pm-helper (Bug 10943)
    
    Switch to using pkexec instead of the sudo helper. This allows
    users to use things such as fingerprint readers and other auth
    methods to verify credentials. A default polkit rule is shipped
    in this patch as well in the org.xfce.power.policy.

http://git.xfce.org/xfce/xfce4-power-manager/commit/?id=9ec0514fd9972373c1875ff3b80054145a445d9f

Bug #10943

Reported by:
haarp
Reported on: 2014-06-06
Last modified on: 2014-08-10

People

Assignee:
Eric Koegel
CC List:
1 user

Version

Version:
Unspecified

Attachments

Use pkexec for pm-helper (28.36 KB, patch)
2014-08-08 20:31 CEST , Eric Koegel
no flags

Additional information