! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[bug] [unrep] Deleting file from desktop freezes system
Status:
RESOLVED: FIXED
Product:
Xfdesktop
Component:
General

Comments

Description flocculant 2014-03-29 15:16:39 CET
The first time I delete anything from the desktop, the system freezes for approximately 30 seconds.

This warning is found in .cache/upstart/dbus.log

** (process:8845): WARNING **: *** Unsupported operation detected on trash directory

** (process:8845): WARNING **: dir: /home/hob/.local/share/Trash/files, file: xubuntu-default-settings_14.04.2.tar.gz, type: 1

** (process:8845): WARNING **: *** Unsupported operation detected on trash directory

** (process:8845): WARNING **: dir: /home/hob/.local/share/Trash/files, file: xubuntu-default-settings-14.04.2, type: 1

Subsequent deletions from desktop in the same session, create no warning and do not freeze the system
Comment 1 Eric Koegel editbugs 2014-03-30 18:19:10 CEST
Created attachment 5401 
Use GIO directly for delete/trash operations

xfdesktop uses Thunar's dbus for trash/delete so I'm not sure why that error pops up, however since the operation doesn't really need a popup window showing the operations progress I wrote a patch to use GIO's built-in functions directly. Let me know if this fixes the issue.
Comment 2 flocculant 2014-03-30 19:28:04 CEST
Used Thad Tintenfisch's PPA with the patch included - file deleted from desktop as expected, with no system freeze

thanks
Comment 3 Eric Koegel editbugs 2014-03-30 19:35:04 CEST
Thanks for testing it, pushed to master in:
http://git.xfce.org/xfce/xfdesktop/commit/?id=d48b40f6623a758ff128f5b22b2bd3e581b5b2a3
Comment 4 Eric Koegel editbugs 2014-06-02 08:47:46 CEST
Reopening since this commit was reverted in http://git.xfce.org/xfce/xfdesktop/commit/?id=c79f244f8f1f2d08892a54cbb820211abad3287d
Comment 5 flocculant 2014-07-14 21:28:19 CEST
Odder behaviour associated with this being seen in Xubuntu 14.10 now.

Same issue with freeze after desktop deletes - now I am also seeing that if I delete, wait for the freeze, moving to a new desktop hangs in addition.
Comment 6 Eric Koegel editbugs 2014-09-22 19:13:51 CEST
*** Bug 11184 has been marked as a duplicate of this bug. ***
Comment 7 francesco_dem 2014-10-02 20:18:19 CEST
Hi, i have the same problem on archlinux x86_64 (64bit)
Comment 8 Julien [nodiscc] editbugs 2014-12-04 19:30:56 CET
Hello everyone, I'm unable to reproduce this on Debian testing/unstable x86.
It would be nice if you could attach your version numbers for xfdesktop4 and thunar (as it seems to be related)

xfdesktop4: 4.10.2-3
thunar: 1.6.3-2

@elfy @francesco_dem, can you still reproduce this bug?
Comment 9 dev 2014-12-04 19:39:06 CET
I'm having the issue with xfdesktop4 v4.11.6-1, thunar 1.6.3-1 .
Comment 10 francesco_dem 2014-12-04 20:12:36 CET
(In reply to Julien [nodiscc] from comment #8)
> Hello everyone, I'm unable to reproduce this on Debian testing/unstable x86.
> It would be nice if you could attach your version numbers for xfdesktop4 and
> thunar (as it seems to be related)
> 
> xfdesktop4: 4.10.2-3
> thunar: 1.6.3-2
> 
> @elfy @francesco_dem, can you still reproduce this bug?

Hi Julien, i have thunar 1.6.3 and xfdesktop : 4.10.3-2.
Comment 11 francesco_dem 2014-12-04 20:15:33 CET
(In reply to francesco_dem from comment #10)
> (In reply to Julien [nodiscc] from comment #8)
> > Hello everyone, I'm unable to reproduce this on Debian testing/unstable x86.
> > It would be nice if you could attach your version numbers for xfdesktop4 and
> > thunar (as it seems to be related)
> > 
> > xfdesktop4: 4.10.2-3
> > thunar: 1.6.3-2
> > 
> > @elfy @francesco_dem, can you still reproduce this bug?
> 
> Hi Julien, i have thunar 1.6.3-2 and xfdesktop : 4.10.3-2.
Comment 12 flocculant 2014-12-08 20:01:07 CET
(In reply to Julien [nodiscc] from comment #8)
> Hello everyone, I'm unable to reproduce this on Debian testing/unstable x86.
> It would be nice if you could attach your version numbers for xfdesktop4 and
> thunar (as it seems to be related)
> 
> xfdesktop4: 4.10.2-3
> thunar: 1.6.3-2
> 
> @elfy @francesco_dem, can you still reproduce this bug?

Yep. 

Running Xubuntu VV dev currently

xfdesktop4:  Installed: 4.11.8-0ubuntu1

thunar:  Installed: 1.6.3-2ubuntu1
Comment 13 Steve Dodier-Lazaro editbugs 2015-02-15 05:25:49 CET
Is the freeze caused by the Thunar daemon needing time to spawn, or by something else?

I have a completely unrelated instance of calling D-Bus via Thunar causing the caller to freeze (Firefox when opening the current folder, according to Mozilla folks currently debugging their use of the FileManager1 D-Bus interface).

Could it be that we should fix an issue in Thunar instead, and that this would take care of the freeze? As I understand it, the progress dialog can be useful when deleting large files from the desktop.

Thanks.
Comment 14 Eric Koegel editbugs 2015-02-15 16:10:40 CET
Moght be, the ~30 seconds sounds like the default dbus timeout. Not sure why it started showing up, especially for the 4.10 branch.
Comment 15 flocculant 2015-02-22 14:37:13 CET
This just popped up in mailbox - I'm now NOT seeing this issue

xfdesktop4 - 4.11.8-0ubuntu1
thunar - 1.6.5-0ubuntu1

I've also got new hardware here now. (not sure if that's of any importance but thought I'd mention anyway)
Comment 16 Langer Alexey 2015-02-28 16:23:23 CET
Up! The problem remains actual.
It seems this is not a D-Bus, because at the time of freezing the entire desktop becomes inactive (does not respond to a click of the mouse).
xfdesktop 4.11.8
Thunar 1.6.3 (Xfce 4.10)
OS Xubuntu 14.04 x64
Three variants of the log .cache/upstart/dbus.log (process:2540 - is "gvfsd-trash"):
1)
** (process:2540): WARNING **: *** Unsupported operation detected on trash directory
** (process:2540): WARNING **:   dir: /home/admin1/.local/share/Trash/files, file: nwjs-v0.12.0-rc1-linux-x64, type: 1
** (process:2540): WARNING **: *** Unsupported operation detected on trash directory
** (process:2540): WARNING **:   dir: /home/admin1/.local/share/Trash/files, file: nwjs-v0.12.0-rc1-linux-x64.tar.gz, type: 1
=========================================================
2)
** (process:2540): WARNING **: *** Unsupported operation detected on trash directory
** (process:2540): WARNING **:     A trash files/ directory should only have files linked or unlinked (via moves or deletes).  Some other operation has been detected on a file in the directory (eg: a file has been modified).  Likely, the data reported by the trash backend will now be inconsistent.
** (process:2540): WARNING **:   dir: /home/admin1/.local/share/Trash/files, file: ubuntu-mate-15.04-beta1-desktop-amd64.iso, type: 1
=========================================================
3)
** (process:2540): WARNING **: *** Unsupported operation detected on trash directory
** (process:2540): WARNING **:   dir: /home/admin1/.local/share/Trash/files, file: sibhost.ru-2014-01-13.zip, type: 1

Successfully activated service 'org.freedesktop.thumbnails.Cache1'

** (process:2540): WARNING **: *** Unsupported operation detected on trash directory
** (process:2540): WARNING **:   dir: /home/admin1/.local/share/Trash/files, file: nw, type: 1

(Thunar:4281): GLib-CRITICAL **: Source ID 48139 was not found when attempting to remove it
(Thunar:4281): GLib-CRITICAL **: Source ID 49096 was not found when attempting to remove it
==========================================================
Comment 17 Eric Koegel editbugs 2015-03-28 12:56:27 CET
So it looks like it was a bug in gvfs which explains why it just
started showing up on the 4.10 branch.
https://bugzilla.gnome.org/show_bug.cgi?id=737473
https://git.gnome.org/browse/gvfs/commit/?id=1f2d2952135a1304b0ed66da1d3d8f60f1e1c06e

So any version of gvfs >= 1.23.1 should be fixed.
Comment 18 Eric Koegel editbugs 2015-05-13 03:33:38 CEST
Closing bug report as it was a bug in gvfs.
Comment 19 Thaddaeus Tintenfisch editbugs 2015-07-11 10:23:54 CEST
*** Bug 12014 has been marked as a duplicate of this bug. ***
Comment 20 Matias De lellis 2015-12-09 04:16:34 CET
Hi Eric,

> Closing bug report as it was a bug in gvfs.

Not completely.. But beyond this discussion, I think I can offer a small improvement.. ;)

> https://github.com/xfce-mirror/xfdesktop/blob/09ce3eb7f79225366c445e5a6639b9b7d0f1ac4d/src/xfdesktop-file-utils.c#L866

These set the watch cursor, but call the dbus proxy so quickly that never display the cursor..

Then (though the name of the function is _async), is doing all the main thread, freezing the desktop all the time that takes the file operations..

If you add these code in the line marked above force to update the gui, and to respond to new events like clicks on the desktop

>        while (g_main_context_pending (NULL))
>            g_main_context_iteration (NULL, FALSE);

The ideal is do this within the dbus interface, but as this constructed now is impossible. :S

Please.. Test.

Regards,
Matias.
Comment 21 md 2018-02-08 14:35:38 CET
(In reply to Matias De lellis from comment #20)
> Hi Eric,
> 
> > Closing bug report as it was a bug in gvfs.
> 
> Not completely.. But beyond this discussion, I think I can offer a small
> improvement.. ;)
> 
> > https://github.com/xfce-mirror/xfdesktop/blob/09ce3eb7f79225366c445e5a6639b9b7d0f1ac4d/src/xfdesktop-file-utils.c#L866
> 
> These set the watch cursor, but call the dbus proxy so quickly that never
> display the cursor..
> 
> Then (though the name of the function is _async), is doing all the main
> thread, freezing the desktop all the time that takes the file operations..
> 
> If you add these code in the line marked above force to update the gui, and
> to respond to new events like clicks on the desktop
> 
> >        while (g_main_context_pending (NULL))
> >            g_main_context_iteration (NULL, FALSE);
> 
> The ideal is do this within the dbus interface, but as this constructed now
> is impossible. :S
> 
> Please.. Test.
> 
> Regards,
> Matias.

Hi, Matias

I heavily suffer from bug 12439 ("Desktop freeze sometimes"), and wanted to see if your patch helps with it. So I've  patched Debian 9's xfdesktop, specifically:

> xfdesktop version 4.12.3, running on Xfce 4.12.
> Built with GTK+ 2.24.30, linked with GTK+ 2.24.31.

with your patch above, and while seems to help slightly, there are still often desktop freezes, especially when a file is sent to trash using "Delete" key in keyboard (and the  DBUS warning message in that bug report is printed occasionally)

Bug #10778

Reported by:
flocculant
Reported on: 2014-03-29
Last modified on: 2018-02-08
Duplicates (2):
  • 11184 Deleting things on the desktop takes several seconds for them to disappear
  • 12014 Huge lag when delete folder or file

People

Assignee:
Eric Koegel
CC List:
10 users

Version

Version:
Unspecified

Attachments

Additional information