Users are seeing this in xsession errors, likely due to desktop files that are odd? would be nice to: a) Print more info here about the offending file(s) b) make it not a critical error if it's not actually critical?
http://git.xfce.org/xfce/xfdesktop/diff/src/xfdesktop-file-icon-manager.c?id=bc48d533bd0dbaaad8d865bd6f26bc9c8f47e042 Is the fix for it. The warning comes from GIO so I can't really control how it looks. It's harmless unless you have --g-fatal-warnings passed in. If this bothers a lot of people I can cherry-pick it and a couple other bug fixes into a 4.10 point release. Nick brought up that idea a while back on #xfce-dev for other components but there didn't seem to be a high interest at the time. Let me know either way!
I guess I would say if there's other more important reasons for a 4.10.x release, this could be added, but it's not worth it just for this. As long as it's fixed in 4.11+ thats fine with me... it doesn't cause any issues, it just makes users think there might be some.
Yeah, I wish I caught that sooner. xfdesktop now crashes on runtime warnings with --enable-debug=full so these are easier to find during development. Marking this bug resolved since it is fixed in 4.11.