! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Invert zoom direction not working as expected
Status:
RESOLVED: FIXED
Product:
Ristretto
Component:
Application

Comments

Description slickymaster 2014-03-13 17:40:19 CET
Expected behavior:
By default, Ristretto zooms in when turning the scroll-wheel forward, and zooms out when turning the scroll-wheel backward.
This setting can be inverted by navigating to Edit -> Preferences -> Control tab, and check the "Invert zoom direction" check box.

What is actually happening:
After checking the "Invert zoom direction" check box it's still zooming in when turning the scroll-wheel forward and zooming out when turning the scroll-wheel backward.

~$ apt-cache policy ristretto
ristretto:
  Installed: 0.6.3-2
  Candidate: 0.6.3-2
  Version table:
 *** 0.6.3-2 0
        500 http://pt.archive.ubuntu.com/ubuntu/ trusty/universe i386 Packages
        100 /var/lib/dpkg/status


~$ lsb_release -a && uname -r

Distributor ID:	Ubuntu
Description:	Ubuntu Trusty Tahr (development branch)
Release:	14.04
Codename:	trusty
3.14.0-031400rc6-generic
Comment 1 Andre Miranda editbugs 2014-05-05 22:18:53 CEST
Created attachment 5475 
Patch

The attached patch solves the problem.
Comment 2 Michael Kogan 2014-09-19 19:29:26 CEST
Also affected, this is the only bug making me use Eye of Gnome 2, would be glad if it gets fixed! However in my case the "Invert zoom direction" check box does not affect the behaviour: Whether it is checked or not, the mouse wheel scrolls through the image list instead of zooming in and out.
Comment 3 Eric Koegel editbugs 2015-01-25 08:00:51 CET
André, works great, thanks! Pushed to master in:

commit 465a9f5bde65cd6af8ef559c43cd0f4421437583
Author: André Miranda <andreldm1989@gmail.com>
Date:   Sun Jan 25 09:49:18 2015 +0300

    Fix invert zoom direction (Bug #10746)
    
    The patch fixes the code so that the invert zoom direction is
    applied when doing a scroll-wheel zoom.
    
    Signed-off-by: Eric Koegel <eric.koegel@gmail.com>
http://git.xfce.org/apps/ristretto/commit/?id=465a9f5bde65cd6af8ef559c43cd0f4421437583

Bug #10746

Reported by:
slickymaster
Reported on: 2014-03-13
Last modified on: 2015-01-25

People

Assignee:
Stephan Arts
CC List:
3 users

Version

Version:
unspecified

Attachments

Patch (3.51 KB, patch)
2014-05-05 22:18 CEST , Andre Miranda
no flags

Additional information