! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Quit/Turn off/Reboot panel needs slight redesign
Status:
CLOSED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description Daniel Lowe 2005-07-11 15:03:45 CEST
The panel to log out of the session currently has three radio buttons to select
an action, a checkbox to select and option, and two push buttons to cancel or
accept the selected actions.  Using radio buttons to select actions is
inefficient and unfriendly.  There should be four push buttons: Cancel, Logout,
Reboot, and Power off.

Reproducible: Always
Steps to Reproduce:
1. Push 'Exit' button in system panel.

Actual Results:  
Dialog using radio buttons to select actions.

Expected Results:  
Should have used push buttons to select actions.

This interface design is particularly irritating when using a tablet.
Comment 1 Benedikt Meurer editbugs 2005-07-11 15:27:10 CEST
Sounds like a pretty good idea, indeed.
Comment 2 Benedikt Meurer editbugs 2005-07-11 15:44:47 CEST
Any idea how the new dialog would look like?
Comment 3 Jasper Huijsmans editbugs 2005-07-13 21:12:13 CEST
Created attachment 272 
Screenshot of proposed dialog layout
Comment 4 Jasper Huijsmans editbugs 2005-07-13 21:14:59 CEST
Created attachment 273 
Proposed dialog layout patch

Preliminary patch. The icons should probably be changed and included in
xfce4-session.
Comment 5 Jasper Huijsmans editbugs 2005-07-13 21:16:22 CEST
Ok, I added a possible (unpolished) patch and screenshot. What do you think?
Comment 6 Jasper Huijsmans editbugs 2005-07-13 21:17:55 CEST
(In reply to comment #5)
> Ok, I added a possible (unpolished) patch and screenshot. What do you think?

Hmm, yeah, it's in Dutch, but I'm sure you'll get the idea ;-)
Comment 7 Benedikt Meurer editbugs 2005-07-14 10:20:16 CEST
Hm, dunno, somehow I don't like the vertical layout. I would prefer a horizontal
layout, but right now I cannot think of a way to display the 4 buttons
horizontally either w/o messing up the width/height balance.
Comment 8 Daniel Lowe 2005-07-14 14:14:55 CEST
(In reply to comment #7)
MacOS 7-9 (don't know about 10) had a horizontal arrangement and it didn't seem
too strange.  I think to look correct, the dialog must be aligned above center
on the screen.
Comment 9 Benedikt Meurer editbugs 2005-07-14 14:22:21 CEST
I don't have any Classic setup around ATM. Can you provide a screenshot of the
Classic logout screen?
Comment 10 Erik Harrison 2005-07-14 23:40:52 CEST
Not sure I have an opinion on this one, usabilitywise. Thinking outloud:

Vertical layouts quickly feel cluttered, from a simple aesthetic standpoint -
that's why we changed the Settings panel layout, as I recall. 

However, standard horizontal layouts look like "yes/no/canel" style dialogs,
especially since we have three effectively four  buttons (shutdown, reboot,
logout, cancel).

I wonder if this is a case of shoehorning functionality into the same dialog
just because internally they're the same, regardless of user perception.
Restarting and shutting down are one group, logging out is another group.
Perhaps they should be seperate dialogs of some type?
Comment 11 Daniel Lowe 2005-07-16 03:35:48 CEST
Created attachment 275 
Screenshot of MacOS classic shutdown dialog

One screenshot coming up...
Comment 12 Jasper Huijsmans editbugs 2005-08-06 07:49:32 CEST
Created attachment 284 
Screenshot of horizontal shutdown dialog

Hmm, so asking for suggestions on the mailing list doesn't really help... 

How about this then: horizontal with shorter labels.
Comment 13 Jasper Huijsmans editbugs 2005-08-06 07:53:24 CEST
Created attachment 285 
patch for shutdown dialog with buttons in a horizontal layout

And the patch, for those who want to try it. Should of course be polished
before real use with tooltips and remembering last shutdown action.
Comment 14 Benedikt Meurer editbugs 2005-08-06 12:53:04 CEST
Hm, no, don't like that one, How about a really plain dialog similar to the
Classic one?
Comment 15 Daniel Lowe 2005-08-08 03:12:06 CEST
(In reply to comment #13)
> And the patch, for those who want to try it. Should of course be polished
> before real use with tooltips and remembering last shutdown action.

I like it the way it is.  It'd also be good to have another image for the
'logout' button.
Comment 16 Jasper Huijsmans editbugs 2005-12-23 12:38:14 CET
Created attachment 371 
'Classic' style dialog

(In reply to comment #14)
> Hm, no, don't like that one, How about a really plain dialog similar to the
> Classic one?

Here's a screenshot. I don't think I like this one :(
Comment 17 Jasper Huijsmans editbugs 2005-12-23 12:39:13 CET
Created attachment 372 
patch for 'Classic' style logout dialog

A patch for people who wish to try for themselves.
Comment 18 Daniel Lowe 2005-12-23 14:54:57 CET
So far, my favorite is the one shown in the attachment on comment 12.
Comment 19 Jasper Huijsmans editbugs 2005-12-28 13:26:30 CET
Created attachment 375 
Updated horizontal layout 

Updated, slightly more polished version of the shutdown dialog with horizontal
layout. 

Benny, you will have to admit it looks better than the current dialog ;-)
Comment 20 Jasper Huijsmans editbugs 2005-12-28 13:28:37 CET
Created attachment 376 
Updated patch for shutdown dialog with buttons in a horizontal layout

Benny, how about letting me commit this and see if there will be a reaction
from users?
Comment 21 Benedikt Meurer editbugs 2005-12-28 13:34:11 CET
The shutdown icon shouldn't be used twice, IMHO. Maybe w/o an icon in the title?
Comment 22 Jasper Huijsmans editbugs 2005-12-28 13:54:34 CET
(In reply to comment #21)
> The shutdown icon shouldn't be used twice, IMHO. Maybe w/o an icon in the title?

Yes, agreed. I'll add a new screenshot.
Comment 23 Jasper Huijsmans editbugs 2005-12-28 13:55:31 CET
Created attachment 377 
horizontal layout (3)

How about this?
Comment 24 Benedikt Meurer editbugs 2005-12-28 14:55:26 CET
Looks pretty much XP-like now. ;-)
Go on and commit it.
Comment 25 Jasper Huijsmans editbugs 2005-12-28 15:25:47 CET
Ok, thanks, I've committed the changes.

Bug #1074

Reported by:
Daniel Lowe
Reported on: 2005-07-11
Last modified on: 2009-07-14

People

Assignee:
Benedikt Meurer
CC List:
1 user

Version

Attachments

Screenshot of proposed dialog layout (17.77 KB, image/png)
2005-07-13 21:12 CEST , Jasper Huijsmans
no flags
Proposed dialog layout patch (8.59 KB, patch)
2005-07-13 21:14 CEST , Jasper Huijsmans
no flags
Screenshot of MacOS classic shutdown dialog (46.83 KB, image/png)
2005-07-16 03:35 CEST , Daniel Lowe
no flags
Screenshot of horizontal shutdown dialog (16.90 KB, image/png)
2005-08-06 07:49 CEST , Jasper Huijsmans
no flags
patch for shutdown dialog with buttons in a horizontal layout (8.63 KB, patch)
2005-08-06 07:53 CEST , Jasper Huijsmans
no flags
'Classic' style dialog (10.59 KB, image/png)
2005-12-23 12:38 CET , Jasper Huijsmans
no flags
patch for 'Classic' style logout dialog (8.13 KB, patch)
2005-12-23 12:39 CET , Jasper Huijsmans
no flags
Updated horizontal layout (14.89 KB, image/png)
2005-12-28 13:26 CET , Jasper Huijsmans
no flags
Updated patch for shutdown dialog with buttons in a horizontal layout (8.85 KB, patch)
2005-12-28 13:28 CET , Jasper Huijsmans
no flags
horizontal layout (3) (13.11 KB, image/png)
2005-12-28 13:55 CET , Jasper Huijsmans
no flags

Additional information