If you change xfwm4 settings (ie theme, focus mode, etc...), they are not saved on logout. xfwm4 will use the old settings on next startup. Reproducible: Always Steps to Reproduce: 1. change a xfwm4 setting, like the theme in use 2. logout / login 3. the previous setting/theme is back
Absolutely, confirmed! Benny, I suspect this might bne this change : Author: benny Date: 2005-06-25 11:17:15 +0000 (Sat, 25 Jun 2005) New Revision: 16063 Modified: xfwm4/trunk/mcs-plugin/xfwm4_plugin.c Log: Don't crash if the MCS plugin is unable to store the settings, a warning telling whats wrong will be emitted by libxfce4util, see bug #1033. Modified: xfwm4/trunk/mcs-plugin/xfwm4_plugin.c =================================================================== --- xfwm4/trunk/mcs-plugin/xfwm4_plugin.c 2005-06-25 11:10:05 UTC (rev 16062) +++ xfwm4/trunk/mcs-plugin/xfwm4_plugin.c 2005-06-25 11:17:15 UTC (rev 16063) @@ -2215,15 +2215,21 @@ path = g_build_filename ("xfce4", "mcs_settings", RCFILE1, NULL); rcfile = xfce_resource_save_location (XFCE_RESOURCE_CONFIG, path, TRUE); - result = mcs_manager_save_channel_to_file (mcs_plugin->manager, CHANNEL1, rcfile); + if (G_LIKELY (rcfile == NULL)) + { + result = mcs_manager_save_channel_to_file (mcs_plugin->manager, CHANNEL1, rcfile); + g_free (rcfile); + } g_free (path); - g_free (rcfile); path = g_build_filename ("xfce4", "mcs_settings", RCFILE2, NULL); rcfile = xfce_resource_save_location (XFCE_RESOURCE_CONFIG, path, TRUE); - result = mcs_manager_save_channel_to_file (mcs_plugin->manager, CHANNEL2, rcfile); + if (G_LIKELY (rcfile == NULL)) + { + result = mcs_manager_save_channel_to_file (mcs_plugin->manager, CHANNEL2, rcfile); + g_free (rcfile); + } g_free (path); - g_free (rcfile); return result; }
Damn, right. The "rcfile == NULL" should be "rcfile != NULL", sorry. Will you fix it or should I?
Done, thanks.