! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Middle Click not Detected
Status:
RESOLVED: FIXED

Comments

Description jes.alpha 2013-12-30 16:27:59 CET
Middle Click not Detected even when changing option to open in new tab or in new window. It doesn't do either.
Comment 1 Helder 2015-01-07 23:45:23 CET
Can you still reproduce this?

On Thunar 1.6.3, when I middle click in the title of a tab, it is closed (as expected).
Comment 2 florian.mortgat 2015-01-09 13:18:00 CET
(In reply to Helder from comment #1)
> Can you still reproduce this?
> 
> On Thunar 1.6.3, when I middle click in the title of a tab, it is closed (as
> expected).

The bug doesn't regard middle click on an existing tab to close it but middle click on a directory, which is supposed to open this directory in a new tab (or new window). The tab-closing behavior is working but the directory-opening one is subject to the single click or double click policy the user has chosen: if the user has selected “single click to activate items”, it will work as expected, but if the user has selected “double click to activate items”, it will require him to double middle click on a directory to open it in a new tab / window, which is not the expected behavior (this single or double click policy should only be applied to the left click but not to the middle or right click).
Comment 3 Harald Judt 2015-01-15 11:22:09 CET
Created attachment 5867 
Make-single-middle-click-open-files-and-folders.patch

Patch to change double middle click to single middle click for opening files and folders. It changes many lines, but only because of adapting the indentions.
Comment 4 Harald Judt 2015-01-15 12:13:41 CET
Created attachment 5868 
details-view-make-single-middle-click-open-files-and-folders.patch

A similar patch is necessary for the details view. The previous patch only handles this for the icon and list views.
Comment 5 Harald Judt 2015-01-15 15:01:48 CET
Unfortunately, one bug with my patches is that now <ctrl> + middle click opens files too, not only directories, which is not a desired behaviour. Without the patches, the item is only selected.
Comment 6 Harald Judt 2015-01-15 16:30:48 CET
Created attachment 5869 
Make-single-middle-click-open-files-and-folders.patch

Revised patch that combines and obsoletes the previous two patches because of their similarity and because they fix one problem:
    Make single middle click open files and folders (bug #10587)
    
    Regardless of the "open on single click" option, double middle
    click is weird and many users will not know about it. What's more,
    on many mice the middle mouse button is hard to press.
    
    So do away with the double middle click and only allow open
    with middle click for folders.

A single middle-click on files will still select a file. Whether or not this should happen should be the topic of another bug.
Comment 7 Peter de Ridder editbugs 2015-01-15 21:25:36 CET
*** Bug 11061 has been marked as a duplicate of this bug. ***
Comment 9 Harald Judt editbugs 2015-02-06 19:02:58 CET
*** Bug 11506 has been marked as a duplicate of this bug. ***

Bug #10587

Reported by:
jes.alpha
Reported on: 2013-12-30
Last modified on: 2015-02-06
Duplicates (2):
  • 11061 'Middle click: open folder in new tab' requires double middle click if 'double click to activate items' on
  • 11506 Middle-click to open new tab is affected by double-click setting

People

Assignee:
Jannis Pohlmann
CC List:
7 users

Version

Attachments

Additional information