! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add a "Change User" button to xfce4-session-logout
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-session
Component:
General

Comments

Description Edoardo Maria Elidoro 2013-09-09 11:38:26 CEST
Created attachment 5149 
Graphical expected results

It would be nice (and coherent to the panel applet) to have another button in the dialog of xfce4-session-logout in order to change the active user.

A mockup of what should (almost) be the graphical result of this improvement is attached to the bug report; the command that could be associated to the "Change User" button is "dm-tool switch-to-greeter" (actually not working just with Slim).
Comment 1 Simon Steinbeiss editbugs 2013-09-09 12:21:25 CEST
I'm not 100% sure about the proposed layout, but I second adding a way to switch users. Being consistent with the panel-plugin seems desirable.
Comment 2 Diego 2013-09-09 12:43:08 CEST
I think this is a great idea! but I don't like the graphic layout
I think also it would be good to support lightdm natively since it supports user switching
Comment 3 Eric Koegel editbugs 2016-06-05 18:45:11 CEST
Added in:
commit a3a388b3568b07de2c4ddeb23da663f2ea623499
Author: Eric Koegel <eric.koegel@gmail.com>
Date:   Sun Apr 24 07:53:07 2016 +0300

    Add a switch user button to the logout dialog (Bug #10345)
    
    If the display manager provides the org.freedesktop.DisplayManager
    dbus API with the SwitchToGreeter call, the switch to user button
    will show up on the logout dialog.
http://git.xfce.org/xfce/xfce4-session/commit/?id=a3a388b3568b07de2c4ddeb23da663f2ea623499
Comment 4 poma 2016-06-07 16:52:20 CEST
$ grep -R 'org.freedesktop.DisplayManager.Seat\|SwitchToGreeter'
light-locker-1.7.0/src/gs-bus.h:#define DM_SEAT_INTERFACE               "org.freedesktop.DisplayManager.Seat"
light-locker-1.7.0/src/gs-listener-dbus.c:                                                "SwitchToGreeter");
lightdm-1.18.0/NEWS:      - Rename ShowGreeter() to SwitchToGreeter()
lightdm-1.18.0/data/org.freedesktop.DisplayManager.conf:    <allow send_destination="org.freedesktop.DisplayManager" send_interface="org.freedesktop.DisplayManager.Seat"/>
lightdm-1.18.0/src/display-manager.xml:    <method name="SwitchToGreeter"/>
lightdm-1.18.0/src/dm-tool.c:                                                "org.freedesktop.DisplayManager.Seat",
lightdm-1.18.0/src/dm-tool.c:                                     "SwitchToGreeter",
lightdm-1.18.0/src/dm-tool.c:                                           "org.freedesktop.DisplayManager.Seat",
lightdm-1.18.0/src/lightdm.c:    if (g_strcmp0 (method_name, "SwitchToGreeter") == 0)
lightdm-1.18.0/src/lightdm.c:    emit_object_value_changed (bus, seat_entry->path, "org.freedesktop.DisplayManager.Seat", "Sessions", get_session_list (session_entry->seat_path));
lightdm-1.18.0/src/lightdm.c:        emit_object_value_changed (bus, seat_path, "org.freedesktop.DisplayManager.Seat", "Sessions", get_session_list (seat_path));
lightdm-1.18.0/src/lightdm.c:    path = g_strdup_printf ("/org/freedesktop/DisplayManager/Seat%d", seat_index);
lightdm-1.18.0/src/lightdm.c:        "  <interface name='org.freedesktop.DisplayManager.Seat'>"
lightdm-1.18.0/src/lightdm.c:        "    <method name='SwitchToGreeter'/>"
lightdm-1.18.0/help/C/user-switching.page:SwitchToGreeter - A greeter session is started. This allows the user to authenticate for a new session or authenticate to return to their current session.
xfce4-session-43e532f/xfce4-session/xfsm-shutdown.c:  const gchar *DBUS_INTERFACE = "org.freedesktop.DisplayManager.Seat";
xfce4-session-43e532f/xfce4-session/xfsm-shutdown.c:  const gchar *DBUS_OBJECT_PATH = "/org/freedesktop/DisplayManager/Seat0";
xfce4-session-43e532f/xfce4-session/xfsm-shutdown.c:                                  "SwitchToGreeter",
xfce4-session-43e532f/xfce4-session/xfsm-shutdown.c:  const gchar *DBUS_INTERFACE = "org.freedesktop.DisplayManager.Seat";


$ ps ax | grep '[x]fce4-session\|[l]ight\|[d]bus'
  876 ?        Ss     0:00 /usr/bin/dbus-daemon --system --address=systemd: --nofork --nopidfile --systemd-activation
 1208 ?        Ssl    0:00 /usr/sbin/lightdm
 1214 tty1     Ssl+   0:01 /usr/libexec/Xorg :0 -seat seat0 -auth /var/run/lightdm/root/:0 -nolisten tcp vt1 -novtswitch
 1273 ?        Sl     0:00 lightdm --session-child 12 19
 1309 ?        Ss     0:00 /usr/bin/dbus-daemon --session --address=systemd: --nofork --nopidfile --systemd-activation
 1338 ?        Sl     0:00 xfce4-session
 1344 ?        S      0:00 /bin/dbus-daemon --config-file=/usr/share/defaults/at-spi2/accessibility.conf --nofork --print-address 3
 1403 ?        Sl     0:00 light-locker


Everything is there but "Switch User" button, within logout dialog, does not "Switch User",
effect is same as with "Log Out" button.
Comment 5 poma 2016-06-08 12:45:41 CEST
(In reply to poma from comment #4)
[...]
> Everything is there but "Switch User" button, within logout dialog, does not
> "Switch User",
> effect is same as with "Log Out" button.

Bug 12639

Bug #10345

Reported by:
Edoardo Maria Elidoro
Reported on: 2013-09-09
Last modified on: 2016-06-08

People

Assignee:
Xfce Bug Triage
CC List:
8 users

Version

Version:
Unspecified

Attachments

Graphical expected results (125.21 KB, image/png)
2013-09-09 11:38 CEST , Edoardo Maria Elidoro
no flags

Additional information