! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Patch] Fix for "Home" and "Open Parent" icons missing from toolbar
Status:
RESOLVED: FIXED
Priority:
Very Low
Severity:
trivial

Comments

Description Nephiel 2013-06-16 17:22:20 CEST
Created attachment 5070 
[Patch] Fix for "Home" and "Open Parent" icons missing from toolbar

Overview:
    On Thunar 1.6.3, the "Home" and "Open Parent" items are shown as text instead of icons on the location selector.
    This happens when using the "toolbar style" location selector, no matter which GTK icon theme is in use (i.e. not a case of icons missing from the GTK theme).
    The "pathbar style" location selector (breadcrumbs bar) has no "Home" or "Open Parent" buttons, so it is not affected.

Steps to Reproduce:
    1) Open Thunar
    2) Enable "toolbar style" location selector (View -> Location Selector -> Toolbar Style)

Actual Results:
    The toolbar changes to show history "Back" and "Forward" buttons as stock GTK arrow icons, followed by "Open Parent" and "Home" buttons as text instead of icons.

Expected Results:
    The toolbar should change to show "Open Parent" and "Home" as the GTK_STOCK_GO_UP and GTK_STOCK_HOME icons.

Proposed Fix:
    This is due to the toolbar style property not being set after enabling the location selector toolbar. Attached is a patch to set it to GTK_TOOLBAR_ICONS, fixing the issue.
Comment 1 Nick Schermer editbugs 2013-07-28 18:28:06 CEST
Applied patch, thanks.

Bug #10179

Reported by:
Nephiel
Reported on: 2013-06-16
Last modified on: 2013-07-28

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Attachments

Additional information