! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
latest git version requires --enable-gtk3 to build .. i.e. gtk2 build fails ...
Status:
RESOLVED: FIXED
Product:
Xfce4-notes-plugin
Component:
General

Comments

Description Derk te Bokkel 2013-05-13 22:21:43 CEST
theme-gtkcss.vala:40.27-40.41: error: The name `CssProvider' does not exist in the context of `Gtk'
				var cssprovider = new Gtk.CssProvider ();
				                      ^^^^^^^^^^^^^^^
theme-gtkcss.vala:40.9-40.44: error: var declaration not allowed with non-typed initializer
				var cssprovider = new Gtk.CssProvider ();
				    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
theme-gtkcss.vala:41.5-41.15: error: The name `cssprovider' does not exist in the context of `Xnp.ThemeGtkcss.update_style_context'
				cssprovider.load_from_path (get_css_path ());
				^^^^^^^^^^^
theme-gtkcss.vala:42.5-42.20: error: The name `StyleContext' does not exist in the context of `Gtk'
				Gtk.StyleContext.add_provider_for_screen (Gdk.Screen.get_default (), cssprovider, 255);
				^^^^^^^^^^^^^^^^
Compilation failed: 4 error(s), 0 warning(s)
make[2]: *** [libnotes_la_vala.stamp] Error 1
make[2]: Leaving directory `/var/tmp/portage/xfce-extra/xfce4-notes-plugin-9999/work/xfce4-notes-plugin-9999/lib'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/xfce-extra/xfce4-notes-plugin-9999/work/xfce4-notes-plugin-9999'
make: *** [all] Error 2

at this point .. 
http://git.xfce.org/panel-plugins/xfce4-notes-plugin/snapshot/xfce4-notes-plugin-7a6ca567716144389ab2cdcbabca6203c1c0e707.tar.bz2


builds fine with gtk3 enabled fails with gtk2 enabled ..
Comment 1 Mike Massonnet editbugs 2013-05-14 00:29:21 CEST
yes, that's known and actually why i hesitated to push the commits.

the problem is autotools which does some unwished things here.

the fix will be coming up as time permits it.
Comment 2 Mike Massonnet editbugs 2013-05-14 00:31:30 CEST
ps: autotools does build every vala file, even if some of them are not present in the sources.

there are some conditions in the Makefile.am like:
#if ENABLE_GTK3
SOURCES = a.vala b.vala
#else
SOURCES = c.vala
#endif

autotools simply builds all the vala files it finds.

a "simple" fix is to append an #if condition inside the vala file itself, but it shouldn't be needed.

Bug #10086

Reported by:
Derk te Bokkel
Reported on: 2013-05-13
Last modified on: 2015-04-14

People

Assignee:
Mike Massonnet
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information